site with dropdown menu(would appreciate some feedback and tips :))

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  JAVASCRIPT 🟡:

  • The way you declared variables are need to be well structured and organized

  ---

  • Take a look at the following example code which describes a preferable way of declaring variables to have a well structured code, this way can't improve performance but it can increase code readability

  const firstName = "Your";
  const lastName = "Name";
  const emailAddress = "[email protected]";
  const password = "supersecret";
  

  • instead try this,

  const firstName =  "Your",
  lastName =  "Name",
  emailAddress = "[email protected]"
  •••                
  •••         // n number of declarations
  password = "supersecret";   // make sure to add a semicolon at end of last declaration
  

  • This single line declaration with separated commas will helps you to have a better structured code and improves readability though

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Fantastic work 👍, but I have some recommendations!

  • Remove width: 100% from the .maincontainer, .maincontainer which is located in div is a block level element which by default takes full width available, so width: 100% does nothing here!

  • Replace height: 100vh to min-height: 100vh in the .maincontainer, the difference is that, when you set height: 100vh to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to set min-height: 100vh, like this in case content is overflowing container will adjust to it!

  1