Site using Flexbox

Community feedback

• 

  Walter Sono•660

  @waltersonoPosted over 3 years ago

  Hi nicholask98

  This is very good, the design looks for both layouts (mobile and desktop)

  Here are my suggestions:

  • Give an alternative description for each image

    • Alternative descriptions helps screen readers users understand your content

  • Try to target your elements by class not by structure

    • If you target your elements by structure that may compromise your design if you were to change the layout even a little bit
    • Instead of targeting the button by ".section > a > .button" just write ".button". If it is a special type of button then give it another class ".button .button--special"

  • Use the correct HTML for each element

    • For the button use a button tag
    • If it is a link then style the link directly do not insert a paragraph tag inside of it
    • This is also helps people with screen readers understand your page and present your content correctly
    • Also helps you reduce the amount of HTML and CSS you write

  • Add and max-width for mobile and center it

    • It will make the mobile design not stretch and will look even better

  Ok, nicholask98

  That is it, keep the good work!

  Marked as helpful

  2

  ---

  

  Nicholas•80

  @nicholask98Posted over 3 years ago

  @waltersono Thanks for the detailed feedback! I'll update this tomorrow with those notes. I really appreciate you taking the time to review my code.

  Best!

  0