Site using bem and scss

Community feedback

• 

  Jessica Strachan•160

  @JessicaStrachanPosted almost 4 years ago

  I don't see anything wrong with your use of BEM naming Theodorus, I think you've used it well :)

  If you wanted to extend it further you could use it on the classes main-title and text-small, for example: card__title and card__text. I think you are showing use of class names being reused with your typography classes and card__social. However I would personally lose the card__social class as you're not applying any styling so it wouldn't make a difference if they were just plain divs.

  2

  ---

  

  Theodorus Clarence•35

  @theodorusclarencePosted almost 4 years ago

  @JessicaStrachan Hi! thankyou for your feedback, its really nice to get feedbacks from fellow developers!

  1

  

  Jessica Strachan•160

  @JessicaStrachanPosted almost 4 years ago

  @theodorusclarence You're welcome!

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Theodorus Clarence! 👋

  Nice work on this challenge! 👍 Your solution looks good and I like how you used vh and vw to place the background SVGs in this challenge to keep them from moving all around when the page is resized! 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Theodorus Clarence•35

  @theodorusclarencePosted almost 4 years ago

  @ApplePieGiraffe Thanks!

  0