Design comparison
SolutionDesign
Solution retrospective
What modification would you make to my code, apart from using grid? Please feedback :P
Community feedback
- @ChamuMutezvaPosted almost 3 years ago
Greetings
- the first heading element of your site has to be an h1 .
- semantic elements such as header, main, footer should be considered ahead of divs. I would have used the div with class container to be the
main
element. - as mentioned by Helios, the
Why us
section should be an unordered list.
Happy coding
Marked as helpful0 - @zeerobitPosted almost 3 years ago
-
the why us section should be an unordered list.. you used the <br> tag in the html to break the lines however you should not use html elements to style your page, leave that to css
-
use rem instead of px since it's not scalable
Happy coding...
Marked as helpful0@AngelG-JAPYPosted almost 3 years ago@zeerobit Thank you very much, I had not thought of ul
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord