Design comparison
Solution retrospective
I'm unsure of the second left box with subscription price, when resizing the window its width stays the same whereas the third box does shrink greatly and I'm not sure if thats the best practice or if it looks better than both shrinking at the same time, I'd welcome any suggestions how to improve my grid especially media queries which I'm new to. Happy coding everyone!
P.S. the scss code is kinda mess, I was really tired to hold focus when doing this challenge sorry :-D
Community feedback
- @AmanpreetSingh1995Posted over 2 years ago
Hi, I have checked your code. I would suggest making the mobile view first and then starting working on desktop view (that's what I do and sometimes I even add a tablet view as well in some designs so the transition from desktop to mobile is easy).
As for the applying media query you have to see for yourself when to add it. Like in this case, if you shrink the screen to 595px you can see that the sign-up button is overlapping with the "why-us" section. This is where you should have made it a mobile view. I know that we are given views on the styles.md but we don't have to follow it. They are given just for reference. When making these types of grids you have to see that all the text is not shirking and there is some padding in between the buttons.
Keep on Coding! :) Good Luck
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord