Design comparison
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Priyanshu Agarwal, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is.
- every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the
main
tag.
The rest is great!
I hope it helps... 👍
Marked as helpful1 - @VCaramesPosted about 2 years ago
Hey @Priyanshu4206, some suggestions to improve you code:
-
The “30-day, hassle-free money back guarantee” is not a heading. It should instead be wrapped in a Paragraph Element.
-
The button was created with the incorrect element. When users click on the button they should directed to a different part of your site; that Anchor Element will allow this to happen.
-
The button styling is incorrect. You want to look at the “style-guide and the “design files” to see how it should be.
-
It is best practice to have separate files for you HTML and CSS code. It helps keep things organized and make it easier to maintain.
Happy Coding! 👻🎃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord