single-price-grid-component-master

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Good job completing this challenge.

  Keep up the good work

  Your solution looks great however I think that the content colored white in the card needs more opacity likewise the button using opacity.

  Marked as helpful

  1
• 

  Hana•960

  @Hanka8Posted over 2 years ago

  Hi Maca, nice job!

  I like your precise design. There is just one little thing i found in your code:

  • When defining heights and widths of the containers, its better to use relative units than px. Thats because when the user changes the font size in his browser, cards containing the text should grow with it to prevent overflow. All font-sizes should be also defined by relative units, because when you use pixels, its not possible to change the font size in browser. On the other side, paddings should be defined by px, because you dont want them to grow with the text. You can try changing the font size in the browser to see what it does to your layout. I suggest reading this article about units. You can also consider using rems instead of px in your media.

  • I noticed tha you are using ´display: flex´ together with ´width´. That can sometimes cause some confusions, consider using ´flex-basis´ instead. You can read about it here

  Keep up the good work ☺

  Marked as helpful

  1