Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

single-price-grid-component-master

Kyvs123 150

@Kyvs123

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Just finished this challenge. I made it responsive.

Constructive criticism and tips to improve my code are always welcome.

Thanks!

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi there! 👋

Congratulations on finishing this challenge! 👏 Good effort on this challenge! 👍

Some areas can be improved.

  • The Sign Up button should be a link in my opinion. I would expect it's going to navigate me to the Signup page if this is a real website. Also, if you have a good reason to keep it as a button then I would recommend adding cursor: pointer so that the user know that it is clickable and adding type="button attribute to prevent the button from behaving unexpectedly.
  • I would recommend writing the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.
  • Prefer unitless numbers for line-height values to avoid unexpected results. The MDN documentation explains it well.👍

That's it! Hope you find this useful! 😁

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord