Vanza Setia• 27,795
@vanzasetia
Posted
Hi there! 👋
Congratulations on finishing this challenge! 👏 Good effort on this challenge! 👍
Some areas can be improved.
- The
Sign Up
button should be a link in my opinion. I would expect it's going to navigate me to the Signup page if this is a real website. Also, if you have a good reason to keep it as a button then I would recommend addingcursor: pointer
so that the user know that it is clickable and addingtype="button
attribute to prevent the button from behaving unexpectedly. - I would recommend writing the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.
- Prefer unitless numbers for line-height values to avoid unexpected results. The MDN documentation explains it well.👍
That's it! Hope you find this useful! 😁
Marked as helpful
0