single-price-grid-component-master

Community feedback

• 

  Kawsar Ahmed Fahad•2,660

  @faha1999Posted about 2 years ago

  Hello, Rayane Boucheraine Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  • You might want to use semantic tags like the <main> to wrap your code, instead of div. like

  <main class="parent">
  </main>
  

  This would help improve accessibility.

  • add the below code to the body. It will center everything

  body {
      justify-content: center;
      align-items: center;
      display: flex;
      height: 100vh;
      flex-direction: column;
  }
  

  • remove the below styles from .parent. It's not necessary anymore.

  .parent {
      /* position: absolute; */
      /* left: 50%; */
      /* top: 50%; */
      /* transform: translate(-50%, -50%); */
  }
  

  • Instead of using px, use relative units like rem or em to get better performance when the information on your page needs to be resized for multiple screens and devices. REM and EM apply to all sizes, not just font-size. You can code your entire page in px and then, at the very end, use the VsCode plugin px to rem to perform the automatic conversion px to rem

  I hope it will work. Happy coding.

  0