SINGLE-PRICE-GRID-COMPONENT USING HTML AND CSS

Community feedback

• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Nicely done.

  • One tip i can give you is that a web developer should always take measurements into consideration.

  • You can open the design with paint 3d and them crop onto the areas where u are designing. It will show you the size in px on the side.

  Marked as helpful

  1

  ---

  

  Sumit Shetty•80

  @Sumit640Posted almost 3 years ago

  @Phalcin Thanks for the suggestion.

  0
• 

  P

  Dave•5,295

  @dwhensonPosted almost 3 years ago

  Hey @Sumit640 lovely job here!!

  Here's some quick feedback that might help you in the future:

  1. Centring content: when you have a single component like this and want to centre it on a page, I would suggest adding dispaly:grid to the body along with place-items:center. This combined with a min-height:100% also on the body should ensure the component remains in the centre of the page - this is handy for quite a few single component challenges like this.
  2. One thing that's worth considering is whether your "button" element is actually a button or a link . The most important thing is what the element will do not what it looks like. This page has a great summary and lots of useful links on this: https://css-tricks.com/buttons-vs-links/ In this case I would probably say it's a link?

  Hope this helps and good luck with the next challenge!!

  Cheers 👋

  Dave

  Marked as helpful

  1

  ---

  

  Sumit Shetty•80

  @Sumit640Posted almost 3 years ago

  @dwhenson Thanks for the suggestion.

  0
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • Always Use Semantic HTML instead of div like <main> <header> , etc for more info

  if my solution has helped you do not forget to mark this as helpful!

  Marked as helpful

  1

  ---

  

  Sumit Shetty•80

  @Sumit640Posted almost 3 years ago

  @Old1337 Thanks for the suggestion.

  1