Design comparison
Solution retrospective
Hi! i would like some feedback for this project. This is my first ever project , i still have a lot to learn please comment your suggestions! Thank you in advance.
Community feedback
- @zeerobitPosted almost 3 years ago
-
in your html i would use the main tag instead of div for the grid class so you avoid getting any accessibility issue also it's more semantic .
-
I would suggest to rename your div1, div2, div3 classes with something more meaningful for instance class ="community" , class="subscription" etc...
-
For the signup button you could make it an anchor tag instead of using the button element since it's supposed to be a link that redirect you to another page. The button element fits better where the user has to submit a form
-
for the why us section you should use an unorganized list instead of the paragraph elements
by the way the paragraphs and the list items don't need to be in bold
Overall you've done well the page looks good .. Also i'm new to coding just sharing what i've learned hope it helps
Marked as helpful0@cosmin870Posted almost 3 years ago@zeerobit Thanks for the suggestions mate! i apreciate! Happy coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord