Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <section> with the main tag and <h3> and <h4> with <h2> to fix the accessibility issues. click here for more on web-accessibility and semantic html
Give the body a background-color of hsl(204, 43%, 93%); and .center a background-color of white (#fff).
To center the section on the page using flexbox or grid instead of margin and padding, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
USING FLEXBOX: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
USING GRID: body{ min-height: 100vh; display: grid; place-items: center; }
There is no need to give the section, .center, .left-card and .right a height value rather give .center, .left-card and .right the same padding value for all the sides.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord