Single-price-grid-component

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 2 years ago

  Hi

  The background color of your last box is too pale making it hard to read (and looks like it might be the wrong font, I’m not sure if my eyes are playing tricks as I’m struggling to read it)

  Most important to sort first though is the html

  • this should not have so many headings in it. I think you’ve misunderstood advice that “headings must go in order”. That’s true but that means within the context of the content. This should be one h1 and then h2s in the other two boxes, as their content belongs to the subject of the first heading. Personally I think the 30 days… content is a paragraph not a heading as it’s so long but that could be my choice
  • the sign up button is not a submit. As a general guide you shouldn’t be using a legacy input to make a button anyway as thats old from before the button element existed, but even if you used a submit button that wouldn’t be the right choice here. Submit buttons are purely for use in forms, but this is not a form. Standard buttons can be used outside of forms eg to toggle content. But looking at This content, “sign up” would navigate someone to a sign up form on click, that means this needs to be an anchor tag, as it would trigger navigation
  • in the last box you need to use an unordered list, not a paragraph tag

  Overall I hope you’re starting to get the importance of choosing the correct html elements. They all have particular meaning/uses and it’s really important to get that right to give your page structure and communicate what the content actually is. It takes some practice to learn and do this automatically but is an essential skill to learn how to translate a design into the most appropriate html

  Good luck

  Marked as helpful

  1
• 

  Demand_dev•650

  @DemandtechPosted over 2 years ago

  @grace-snow... Hello Ma'am, thank you very much for the enlightenment, I have made some changes with your correction, I hope you can still help me to check again if I get it right... I waited until I was sure I did everything right before I replied

  0