single-price-grid-component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Ibrahim! 👋

  Congratulations on finishing this challenge! 👏 Good effort on this challenge! 👍

  Some areas that could be improved.

  • Always specify the type of the button element. It's going to prevent the browser from behaving unexpectedly.
  • header inside the main element won't have any semantic meaning but at the same time, I don't think I will hurt the accessibility of the site. So, my recommendation is to use div instead.

  One useful tip is to write the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.

  That's it! Hope you find this useful! 😁

  1

  ---

  

  Ibrahim•180

  @Ibrahim-EltoukhyPosted over 2 years ago

  @vanzasetia Thank you very much, your comment is very helpful and I appreciate looking to my code. I will be thankful if you always look at my codes and give me such good observations. Also I will be happy to accept my friendship. Thanks again

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Ibrahim-Eltoukhy You're welcome! I've no reasons to not accept your friendship so feel free to contact me on Slack. 😉

  Marked as helpful

  1
• 

  Amanpreet Singh•550

  @AmanpreetSingh1995Posted over 2 years ago

  Hi, very well done, Good work. But there is a slight issue in the mobile design, in the price component you have a border-left radius of 5 px, I don't know whether you have that in the mobile design or not but you need to remove it from the mobile design because there is a white background showing. Other than that, your code looks good. Keep Coding! Cheers

  1

  ---

  

  Ibrahim•180

  @Ibrahim-EltoukhyPosted over 2 years ago

  @AmanpreetSingh1995 Thank you very much, your observation is very helpful and I will fix that. Thanks again

  0