Single-Price-Grid-Component

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hello again :) The desktop version looks great but the mobile version needs some work - the card is still 55vw which makes it really small on the screen and because the height is set in the desktop version, you needed to set overflow:scroll, I think it's more natural to scroll the whole screen rather than just the element. You could set height: max-content to get rid of that problem, I think. Also on 1024px (iPad Pro size) there's white gaps between the coloured backgrounds.

  I found this article that explains BEM methodology simply but like I said it's not a must and you can message me if you want to talk about it more! :)

  0

  ---

  

  Kowacka Malgorzata•50

  @kowackagPosted over 3 years ago

  @AgataLiberska Thank you one more time :) I corected it a little bit.... I hope than now It works. I have to practice more :(

  0

  

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  @kowackag don't get discouraged, that's why we're all here :) two things that helped me a lot is reviewing other people's solutions - if you notice an issue, you can play around in the dev tools to see if you can find what is causing it and how you would fix it. I also went through a video tutorial by Jessica Chan on youtube when she did an intermediate challenge (it was a full landing page) - that helped me figure out my own workflow and how to approach problems. Just make sure you don't get stuck in tutorial hell :)

  0

  

  Kowacka Malgorzata•50

  @kowackagPosted over 3 years ago

  I will not discourage :) @AgataLiberska, Thank you one more time for your tips!

  0