Skip to content
Submitted over 1 year ago

Single-Price-Grid, Grid for basic Layout + Flex within each cell

Moritz Rose•90
@moritzrose
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I am really proud of how this turned out, I tried to implement more rem instead of px and also classes instead of html tags in my css to style the page. The media query is set for any mobile device below the width of tablets, which are wide enough on the other hand to show the normal website properly. Only thing I am concerned about is setting the height of my body to 100vh in order to be able to center my container. Is that an anti pattern? I heard, that just setting it to 100vh might cause problems.

Also, setting the width of my container to 45rem is just, because I could visually check if it looks good, but it doesn't feel proper. Is there a standard width or something, I should use instead, or is the width actually something I have to chose depending on how it looks and how I feel about it?

Last thing, would you implement a minimum width for the mobile version, so that it doesn't get squeezed to a ridiculous amount? Where would you do that?

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    POINTING CURSOR ↗️:

    • Looks like the component's button element has not a pointer, this property plays a major-role in terms of both UI & UX
    • The cursor: pointer CSS property is important for button-like elements because it changes the cursor from the default arrow to a pointer when hovering over the element. This provides a visual cue to the user that the element is clickable and encourages interaction.
    • In terms of UI/UX, using cursor: pointer helps to improve the usability of the interface by making it easier for users to identify interactive elements. It also helps to provide feedback to the user by indicating which elements are clickable and which are not.
    • So we want to add this property to the following button element
    .body-left .button {
   cursor: pointer;
}
    • Now your component's button has got the pointer & you learned about this property as well

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    1
    Moritz Rose•90
    @moritzrosePosted over 1 year ago

    I knew already, but simply forgot :D anyway thank you for your great feedback! @0xAbdulKhalid

    0
    Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    @moritzrose Glad you found it helpful ! 🤠

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord