Skip to content
Submitted over 3 years ago

Single-Page Interactive Landing Page - CSS, JS

prakash•250
@mewebbie
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Room homepage
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

I feel I kinda accomplished the task, but maybe I need to work on writing clean code? This is the first time I've accomplished something this complex(atleast to me), would love to hear feedback on how can I improve.

Community feedback

  • Amon•2,560
    @A-amonPosted over 3 years ago

    Hello! It looks good, so is the responsiveness.

    I have a few suggestions:

    1. Use tags like header, main and footer. E.g. main tag for the main content.

    2. Use button tags for the slider control. Using the appropriate tags is important for screen reader users. :)

    3. You can try using media queries in CSS or picture tag in HTML for switching between the hero images.

    4. Have a separate JS file for JS code.

    5. You can try using after selector for the Shop Now button's arrow. But your current one is good too!

    1
    prakash•250
    @mewebbiePosted over 3 years ago

    @A-amon Your feedbacks are very much appreciated Amon. Will take care of them all in future ;)

    0
    Amon•2,560
    @A-amonPosted over 3 years ago

    @mewebbie Glad to help!

    0
  • Jean•335
    @JeanMiesesPosted over 3 years ago

    Great job Bro. I took a quick look at your code. It looks pretty clean. My only suggestion is don't use var when creating a variable. Instead, use let or const.

    0
    prakash•250
    @mewebbiePosted over 3 years ago

    @JeanMieses Sure bro and thanks a lot :)!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord