Single Pricing [HTML, SASS]

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Hi Florin,

  If you add the border radius this will be closer to the design.

  I find it quite strange on mobile that it's scrolling inside the card rather than on the mobile screen. Is that intentional?

  Also there are some points for Improvement in Your html.

  It's important for headings to go in sequential order, and the price line isn't really suitable for a heading.

  I also think you're misusing sections at the moment. This whole component would qualify as a section but the parts that make it up don't really. Sections should only be used for major chunks of content in a document, like content you would see listed on a contents page.

  I hope this is helpful feedback for you. Good luck with this and the other challenges

  0

  ---

  

  Florin Pavel•240

  @florinpavel22Posted almost 4 years ago

  @grace-snow Hi, these should be fixed now. Thank you for your feedback, I really appreciate it!

  0

  

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  @florinpavel22 the scrollbar is fixed but the headings are still not right. There should be one higher level heading for join our community - that's the heading for this whole component, so should be a h1 or h2. Then the 3 headings after that should all be one level down, either h2 or h3. Price shouldn't be a heading and no h5s should be present at all.

  Does that make more sense?

  0