Single price - using HTML, CSS, grid, BEM, NPM scripts, Sass (scss)

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Awesome work again, Matěj! You've done a really good job on this project. I've got a couple of small recommendations after looking at your code:

  • You're using more than 1 h1 on the page, which I would recommend avoiding. This is for accessibility reasons, as screen reader software will often use the h1 as the page title, so there should only be one of them. h2-h6 can have as many as you like.
  • In the design, the grid component has its width restricted and it's centered on the page. Whereas your component stretches the full width of the screen. So one next step would be a quick re-working to get it looking as close to the design as possible.

  Your project looks great though, keep it up! 👍

  1

  ---

  

  Matěj Kubíček•130

  @matejkubicekPosted almost 5 years ago

  @mattstuddert Thx for feedback. Changes are made.

  • to point 1 - In the course of teaching I solved the problem with the element h1 and I found this - I know that opinions differ on this. I'd rather use only one element h1 in my projects.
  • to point 2 - I wasn't quite sure of the this task. Now it should be relatively fine.

  Don't think I want to resist. I really appreciate any comments and opinions in my study. Thank you very much for your interest.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @matejkubicek you're welcome! Yeah, opinions differ a lot on the h1 issue. I stick to a single h1 for the page title and typically use h2 elements as the primary heading for things like section, aside, etc.

  Nice work on the changes. Your project looks really good!

  1

  

  Matěj Kubíček•130

  @matejkubicekPosted almost 5 years ago

  @mattstuddert Thank you. I'll follow your recommendation.

  0