Design comparison
Solution retrospective
I realized that the content should be more to the left. Had some trouble aligning some items, advice needed. I also noticed some of my items would be more to the left or right than others. Need advice on media queries and key frames, a link to a guide could also help. All advice greatly appreciated/needed. Looking for a in-depth guide to media queries and keyframes
EDIT: JUST NOTICED SOME POSITIONING ERRORS WITHIN MY BUTTON CLASS, WILL UPDATE AND REUPLOAD. unclear as to what happened before pushing the repo to GitHub.
Community feedback
- @vanzasetiaPosted about 2 years ago
Hi there! 👋
There's no need to re-upload with a new solution. You can just update the screenshot instead.
Anyway, as visually you may already notice that it looks different from the original design. I recommend trying to make the site looks closer to the design.
Some suggestions:
header
is not used as a text wrapper. It is a landmark element that is used to wrap logo and navigation links. Use a heading tag instead.- There should not be text in
span
anddiv
alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element. - Always specify the
type
of thebutton
. - The
main
closing tag should appear before thesection
closing tag. For more information see the result of the HTML validation
<main> <section> ... </main> </section>
I hope this helps! Happy coding!
Marked as helpful1@huey-ioPosted about 2 years ago@vanzasetia Thank you , I appreciate the help alot. Looking forward to your advice in the future aswell. Happy Coding
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord