Design comparison
Solution retrospective
Fun challenge! Might add some animations later. Thoughts :)
Community feedback
- @mickygingerPosted over 4 years ago
Hey Oka, this looks great!
You might want to just rethink your margin on the
.container
, as generally we like to give a little more margin at the bottom than at the top. It's an optical illusion but it makes the container feel more stable.Also you may find it easier to choose more descriptive class names.
.box-one
,.box-two
is rather arbitrary and can get confusing as the design moves through several iterations. Something like.primary
,.secondary
,.cta
etc may be easier to work with.Keep up the good work! 🎉
2@okawibawaPosted over 4 years ago@mickyginger Thank your for the feedback, Micky! Ohh I see, I'll keep that in mind! Yes haha, I ran out of ideas of class names at the time, it was 4 AM in the morning and I had just finished the Intro Component page, basically burnt out but wanted to keep going, so I decided to just name it like that, I even thought to myself that naming classes like this will get back to me one day. I will definitely change it later, thank you!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord