Design comparison
SolutionDesign
Solution retrospective
I welcome feedback about my code... I wonder what best practices, workflow, or ways to approach the solution would be better than they way I did it. Thanks!
Community feedback
- @ApplePieGiraffePosted almost 3 years ago
Hi, DNel! 👋
Nice job on this challenge! 👏 Your solution looks pretty good and is responsive! 😀
I'd like to suggest,
- Vertically centering the card component in the viewport by adding
min-height: 100vh
to thebody
and then perhaps turning thebody
into a flex container to easily center the card component inside it. - Using a link or button element for the sign-up button instead of a regular
div
element. Doing so will make your HTML more semantic and help keyboard users to navigate to and interact with that element.
Hope those one or two tips are helpful. 🙂
Keep coding (and happy coding, too)! 😁
Marked as helpful0 - Vertically centering the card component in the viewport by adding
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord