Single price grid using HTML, CSS grid

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Abbas Saad! 👋

  Nice to see you complete another challenge! This one looks good and responds nicely! 👏

  I only suggest perhaps adding a max-width to the card component in the mobile layout since it is just a wee bit wide when the layout first changes from desktop to mobile. 😉

  I think making the color of the button a slightly darker shade of green (as in the original design) to make the text of the button a little easier to read would be a good idea, too.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Abbas Saad•260

  @AbbasSaad27Posted almost 4 years ago

  @ApplePieGiraffe Hi! Thanks a lot for the feedback! Thanks for the suggestions too! I am looking into those now. This challenge was missing some colors in its style guide file. So I had to figure out on my own :') I kind of missed the button's color. Thanks again for pointing that out!! Happy coding! :D

  0
• 

  Steffan Hatlestad•90

  @befflusPosted almost 4 years ago

  Looks like there could be an issue with the button in desktop view. On my PC the button gets bigger than its container. Check out the margins for this maybe :-)

  1

  ---

  

  Abbas Saad•260

  @AbbasSaad27Posted almost 4 years ago

  @befflus Hi! Thanks for pointing out that issue! Can you tell me what is your screen's resolution? I tried many resolutions but the button doesn't get bigger than its container. Maybe if I know your resolution, then I could fix it. Thanks a lot for the feedback!

  0