Design comparison
SolutionDesign
Solution retrospective
What can I improve in terms of best practices?
Community feedback
- @DevibtissamPosted over 2 years ago
well done, but it seems like you forgot to work on the media query for mobile, and be aware of your paddings and margins try to make it a little bit like in design given
1@devesht21Posted over 2 years ago@Devibtissam Will take care about that next time. Thank you for the valuable feedback!
0 - @RioCantrePosted over 2 years ago
Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…
- Remove unnecessary code to keep it clean
- Add the hover state of the button
Other than that...
- The HTML structure is well organized and readable
- Proper usage of semantic tags
- Well done in using proper properties in styling
- The project is responsive and utilized the details based on the original design
Above all, The project is awesome! Keep it up!
1@devesht21Posted over 2 years ago@RioCantre Just forgot about the hover states😅. Will take care of that next time. Thanks for your feedback!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord