Design comparison
Solution retrospective
I have found difficulties while making it responsive. Any suggestion will be welcomed. Thank You:)
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @HarshBehera!
Your solution looks excellent!
I have a few suggestions for improvement:
- First: You set
width: 100%;
for the body. In this case, you don't need to do that, because you already have this setting by default.
body { width: 100%; /* you can remove this line */ }
- Second: For semantic reasons, and since that is the main title of the screen, you can replace the
<h2>
with<h1>
.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Third: Since the Sign up button is a clickable element, it's nice to add
cursor: pointer;
to it. It gives the user a visual indication that's clickable. This improves accessibility.
I hope it helps!
Other than those details, you did a great job!
1@HarshBeheraPosted 10 months ago@danielmrz-dev Hey Thank You for this analysis will take care of these points in subsequent projects.
1 - First: You set
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord