Submitted almost 4 years ago
Single price grid using HTML and CSS (Flexbox)
@Jose-Angel-Rey
Design comparison
SolutionDesign
Solution retrospective
Hello everyone!! This is my second Frontend Mentor challenge and I would like to receive your feedback regarding:
β’ HTML structure π
β’ Responsive design π₯π»π³
β’ Application of BEM
and if you have any recommendations about something that i need to improve it would be great ππΌ
Community feedback
- @MishaHernandezPosted almost 4 years ago
Hi Jose!
- You are using flexbox in the body to center the main container horizontally and vertically but the container has margins assigned (
margin: 10% 0px 5% 0px
) so a vertical scroll is generated in the desktop view. An alternative is to remove these margins and assign the body aheight: 100vh
. Greetings and continue with the challenges.
3@Jose-Angel-ReyPosted almost 4 years ago@MishaHernandez Thank you so much for your feedback ππΌ . I already fixed the errors with the margins. I hope you can see it again π¨πΌβπ»
0@MishaHernandezPosted almost 4 years ago@Jose-Angel-Rey Thats very good! It is totally centered π
0 - You are using flexbox in the body to center the main container horizontally and vertically but the container has margins assigned (
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord