Design comparison
SolutionDesign
Solution retrospective
Hi, it's my fourth challenge. it's not so responsive, I hope you can leave me any feedback. Thx :)
Community feedback
- @al3xbackPosted over 3 years ago
Nice work, Achmad!
Here are a few feedback:
-
i would recommend to not using percentage margin to move the container to center. we can easily add 'justify-content: center' to body as it is already using flex. and let's just add max-width to that container.
-
for the class naming, it would be better if we consistent using lowercase than capitalize.
I hope those will help! :)
0@AchmadAkifPosted over 3 years ago@al3xback thanks for your feedback sir, it helps a lot
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord