single price grid using css grid

Community feedback

• 

  Angelo Barbarulo•280

  @JorahhhPosted over 2 years ago

  I think you forgot to put the border radius at the whole grid.

  Just put in the main container:

  ‘Border-radius: 10px;’ (or less)

  And also in the mobile version in the first and last square.

  This time you have to do in the first square:

  Border-top-right-radius: 10px Birder-top-left-radius: 10px

  …and in the last one:

  Border-bottom-right-radius:10px; Border-bottom-left-radius: 10px;

  For the rest, it seems fine. Nice job! 😀

  Marked as helpful

  0

  ---

  

  Ibtissam•260

  @DevibtissamPosted over 2 years ago

  @Jorahhh oh I completely forgot about border-radius, thank you so much for your feedback

  1
• 

  T

  Grace•31,270

  @grace-snowPosted over 2 years ago

  Hi

  It's really important to Indent your code consistently. Your code editor should even be able to do this for you.

  It's also important to be more aware of html semantic structure. You cannot skip heading levels like this, page content should be contained by landmark elements (a main element, not just sections which are fairly meaningless), and that button should be an anchor tag because it would trigger navigation.

  The only other styling issue I notice that's not already mentioned is the content touches the sides of my phone screen. There should always be some margin around the card or padding on an outer wrapper to prevent this

  I hope this helps you

  0