Design comparison
Solution retrospective
Hello guys. Greetings from Brazil. I would appreciate a lot if you give me your feedback about this project. Thank you very much.
Community feedback
- @EmmanuelHexerPosted almost 3 years ago
Congratulations Vinicius on completing this challenge.
-
Note that header tags are used so that the browser and search engines can identify what they are. They are not used so that the headers becomes big or small.
-
Use one h1 for every webpage, then you move on to h2. If you have other headers in the same section use h3. This will fix your accessibility issues also.
I hope this helps.
Marked as helpful1@viniciusdsv93Posted almost 3 years ago@Phalcin Thanks a lot Emmanuel! About the headers, in this case i should put the entire content of the page inside a header tag, or is it better to create an empty header tag and keep the content inside a main tag?
0@EmmanuelHexerPosted almost 3 years ago@viniciusdsv93 Just place headings in a header tag like, Lets say
<h1>Random Text</h1>
. So then if you get to a second header in your sections you use <h2>. By dont place the entire content of your page in a header tag.Marked as helpful0@viniciusdsv93Posted almost 3 years ago@Phalcin Alright, thanks a lot Emmanuel!
0 -
- @NaveenGumastePosted almost 3 years ago
Hello VINÍCIUS DOS SANTOS VERISSIMO ! Congo 👏 on completing this challenge
Let's look at some of your issues, shall we:
-
You are getting Accessibility Issues because you are not using heading in order for Ex:
h1
first and thenh2
,h3
and so on Learn more on Semantic Elements -
Use the given font-weight from the style guide on all the text
that's all...
happy Coding😀
Marked as helpful0@viniciusdsv93Posted almost 3 years ago@Crazimonk Thanks, Naveen! I'm going to pay attention for that!
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord