Single price grid component

Community feedback

• 

  P

  Darkstar•1,100

  @DarkstarXDDPosted 11 months ago

  Looks good. Couple of things I noted.

  • The text in "Why us" section should be list items.

  <h2>Why Us</h2>
          <ul>
            <li>Tutorials by industry experts</li>
            <li>Peer & expert code review</li>
            <li>Coding exercises</li>
            <li>Access to our GitHub repos</li>
            <li>Community forum</li>
            <li>Flashcard decks</li>
            <li>New videos every week</li>
          </ul>
  

  • I think it's much more cleaner if you put the padding: 0 and margin: 0 in the *, instead of .container.

  * {
      padding: 0;
      margin: 0;
      box-sizing: border-box;
  }
  

  • You should use rem when defining font-sizes instead of px. source

  1

  ---

  

  raya•2,870

  @rayaattaPosted 11 months ago

  Thanks for the feedback I didn't use

  *  {
  Margin:0;
  Padding:0; 
  }
  

  because I would have to re-write the margins and padding for everything. Talking about using pixels I am currently trying to learn clamp(). Thanks for the correction on the why us section. Your feedback is invaluable. @DarkstarXDD

  1