Single Price Grid Component with HTML, CSS, BEM

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Neit

  Well done! Congrats.

  I've just checked your HTML structure and preview site by the inspector:

  • I'd recommend learning more about headings: h1-h6 and semantic tags (why they matter). The h1 is an HTML tag that indicates a heading on a website and normally used once on the page => but this is still a big question mark for me and I am also checking it out;
  • remove style CSS and transfer them to the CSS file;
  • remove unnecessary comments from the file;
  • third card: don't have to use br tag, check more information about ul and li tags (unordered list, list item). This is an answer to your question.
  • the footer hasn't been added;
  • you have used the button in this challenge. I'd recommend reading this article from the blog **CSS-Tricks:A Complete Guide to Links and Buttons.
  • also, the outline of the button is set to none. Please, check another subject which is accessibility (this is a huge area but step by step you will get to know the fundamentals).

  Please, don't forget to upvote any comments on here that you find helpful. That's it from me. Hopefully, it will help you.

  Greetings :D

  2

  ---

  

  N E I T•390

  @NiteAriePosted almost 4 years ago

  Really appreciate the feedback, will do.

  • On the h1-h6, this is the opinion from the w3.org group h1–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. I used h1 in different sections. Source
  • Yeah, I will look further into the topic accessibility

  Thank you very much

  1

  

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  @NiteArie

  Thanks for your answer. I know there were rules of h1 tag usage that came from old document outlines. We have new rules based on the HTML5 document outlining algorithm. I am going to read about it more because opinions are very different and quite often opposite to each other. Anyway, it is not easy to decide how many sections do we need in the project, how to divide it for sections etc. but IMO this project single price grid doesn’t need three sections and 3 h1 :)

  1

  

  N E I T•390

  @NiteAriePosted almost 4 years ago

  Thank you for the answer, I will read more into "HTML5 document outlining algorithm"

  0