Single price grid component with grid

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted about 4 years ago

  Hello, Fawad Mehmood! 👋

  Well done on this challenge! Your approach responds well and your code looks straight forward. I would suggest:

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • If you would like your code to look clearer read about Block, Element, Modifier. BEM is naming convention methodology that helps you to create reusable components and code sharing in front-end development.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Fawad Mehmood•410

  @fawadmehmoodPosted about 4 years ago

  Hi @tediko, Thank you very much for this feedback. I will definitely work on these suggestions.

  0
• 

  Anna Leigh•5,135

  @brasspetalsPosted about 4 years ago

  Hi, Fawad Mehmood! Good job on this challenge - it responds very nicely and you did a great job matching the design! 👍

  I have a few quick suggestions to make it even better:

  • Adding a max-width to your desktop layout to prevent it from getting stretched on large (i.e. 1920px) screens.
  • Adding cursor: pointer as well as a :hover state to the sign up button would be a nice touch and better show interactivity.

  0

  ---

  

  Fawad Mehmood•410

  @fawadmehmoodPosted about 4 years ago

  Hi @brasspetals, Thank you very much for this feedback. I will keep that in my mind.

  0