Design comparison
SolutionDesign
Solution retrospective
I created my solution using Css Grid. I would appreciate if you point out the deficiencies or errors you see.
Community feedback
- @bagas-defandiPosted over 2 years ago
Hi Erin Seven!
congratulations on completing this challenge!
I have a few suggestion for this:
HTML
- I prefer to use
<a>
tag for the button, because sign up button will bring user to other page, I will use<button>
tag when there is interactivity like search button, hamburger menu, submit form.
CSS
-
set
border-radius
andoverflow hidden
to the<main class="gridcontainer">
so you don't have to set it to individual corners. -
I recommend you to use
rem
unit forfont-size
notem
units, for more explanations you can see this video
I also did this challenge with Grid, I use g
rid-template-areas
to make it responsive, you can see my solution hereI hope it helps you 😊
Marked as helpful1 - I prefer to use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord