Single price grid component using SCSS

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Hiyo,

  Your solution looks pretty good! I'd add a few thoughts though:

  1. Read up on what br element is used for! You don't want to use it here. In general, if you'd like to set a width of a p (I'm assuming that's why you added a br here?), you could use width, max-width or add some inline padding.

  2. Logically "Monthly subscription" and "Why us" headings should be on the same level instead of being different h2 and h3 headings.

  3. In the Why us section, you're using a p where there's supposed to be a list of reasons why people should choose to use the product the component advertises. Understanding the content help you choose the right html tag. Here I think a ul would do better, with each point being an li.

  4. Your container isn't centered before width hits 768px, display: grid is only applied when the screen gets larger than that.

  Hopefully this helps a bit! :)

  Marked as helpful

  1

  ---

  

  Mohamad Adithya•290

  @mohamadadithyaPosted almost 3 years ago

  @FluffyKas thanks for your feedback and advices, it's help me a lot ;).

  0