Single Price Grid Component using Sass

Community feedback

• 

  Renszo Camacho•1,615

  @RenszCamachoPosted almost 4 years ago

  Hiya 👋🏻
  Nafsuki.

  Good job 👏👏👏. You have done a fantastic job on this challenge 👌, just one suggestion, on the landscape mobile, it doesn't look good,

  body {min-height: 100vh, margin: 4rem 0} instead of just height. and adding some margin-top and bottom

  Nice solution!!! 💯 Stay coding🧑‍💻

  3

  ---

  

  Nafsuki•245

  @NafsukiPosted almost 4 years ago

  @RenszCamacho Thank you very much for the constructive feedback & suggestion! I have revised the code following your advice! I hadn't really tested on landscape mobile mode, so your advice was very helpful, thank you!

  I have one question. I have tried landscape mode on my iPhone, but I couldn't really see the differences. Could I simulate mobile landscape on google dev tool?

  1

  

  Renszo Camacho•1,615

  @RenszCamachoPosted almost 4 years ago

  @Nafsuki You couldn't see any is because you overwrite the min-height. cascade rule.

  your code is like so body{min-height: 100vh; height: 100vh} . Remove the height and keep the min-height.

  And yes the browser inspector, I use google chrome. right-click, inspector and Ctrl + Shift + M, if you use a Mac, replace Ctrl to Cmd.

  Hopefully, it helps.

  1

  

  Nafsuki•245

  @NafsukiPosted almost 4 years ago

  @RenszCamacho THANK YOU SO MUCH!!!! I could check it on google chrome inspector & now I see the differences you meant!! I have revised the code & I'm so thankful to your advices!! It helped me a lot!! Big thank you!! :))!!!

  0

  

  Renszo Camacho•1,615

  @RenszCamachoPosted almost 4 years ago

  @Nafsuki No worries. I'm glad it helped you.

  1