Submitted almost 3 years ago
Single price grid component using HTML, SASS, JS and BEM.
@stebanc
Design comparison
SolutionDesign
Solution retrospective
I'm trying to write clean HTML and CSS code, so any feedback will be appreciated.
Community feedback
- @pikapikamartPosted almost 3 years ago
Hey, really nice work on this one. The desktop layout looks really great I think and the site is responsive which is really nice. The mobile state looks great as well.
Here are some suggestions on the site:
body
tag has afont-size: 400
which is an invalid value, check that one out.- Removing the
position: absolute
from thefooter
would be really nice so that it won't get in the screen's way. If you try to inspect the site from dev tools at the bottom, thefooter
is stuck in front of the main-content. - Remember that for every page of a site, a single
h1
is needed. For this one, you could replace the firsth2
to anh1
so that it would be present in thedom
. Just remember to change the second text below it to a higher heading tag level or just usep
tag on it.
Those only since the site looks really nice to be honest. Again, awesome work on this one.
Marked as helpful0@stebancPosted almost 3 years ago@pikapikamart Thank you for your comment and suggestions! This helps me write better code.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord