Single Price Grid Component using HTML, CSS and CSS Grid.
Design comparison
Solution retrospective
I welcome all feedback for this solution, thanks.,
Community feedback
- @VCaramesPosted about 2 years ago
Hey @dquindara8, some suggestions to improve you code:
- To center you content to your page, add the following to your Body Element:
body { min-height: 100vh; display: grid; place-content: center; }
-
There are three headings in this component; “Join our community”, “Monthly Subscription”, and “Why us”. They should be wrapped in heading elements.
-
The button hover styling is incorrect. You want to look at the “style-guide and the “design files” to see how it should be.
-
The “Why Us” list should be created using an Unordered List Element along with the List Items Element.
-
Increase the size of the component to better match the FEM example.
Happy Coding! 👻🎃
0 - @AdrianoEscarabotePosted about 2 years ago
Hi Quindara Corbin, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is.
- every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the
main
tag.
The rest is great!
I hope it helps... 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord