Design comparison
SolutionDesign
Solution retrospective
Hi all, still pretty new to this so any feedback much appreciated.
Community feedback
- @Zy8712Posted 12 months ago
Your site looks pretty good. Some things that stand out to me:
- I see that you used
display: grid
. If you choose to use this you should useplace-items: center
to center the box as opposed tojustify-content: center
andalign-items: center
, which are commonly associated withdisplay: flex
- for the third box, the "Why Us" box, you should use an unordered list to list out the items not line breaks. So it should look something like this:
<ul> <li>Item 1</li> <li>Item 2</li> <li>Item 3</li> </ul>
- one last thing I noticed is that when the window size is small, a part of the box gets cut off. So I suggest that you add in media query values to switch your site into a mobile-friendly layout. To read more about media queries and responsiveness, you can read this and this.
Hope you find this feedback userful 👍
Marked as helpful0 - I see that you used
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord