Single price grid component using grid

Community feedback

• 

  Riley•260

  @rileydevdznPosted over 1 year ago

  Hi! Congrats on completing the single price grid component!

  Here's a couple of suggestions:

  • It looks like you're assigning some headings (h1, h2, etc.) based on visual appearance. Headings (<h1>-<h6>) are section headings; semantically, they act as indicators that "hey here's a new section of content!" Join Our Community is perfect as the h1 (nicely done!) and both Monthly Subscription and Why Us are great as lower-level headings (like an h2 or h3), as they represent new sections of content inside the card.
  • You don't need to visually hide the h1 or repeat its content with an h2, just use the h1.
  • The price ($29) doesn't introduce a new section of content, so it would be better as a <p> element. You can use CSS to make the font-size of this element bigger and bolder, instead of using an h2 element.

  Good job using CSS Grid and global variables in your build! My suggestions were for semantic HTML, is there a particular area you were not sure of? Like how you structured or styled a specific element?

  Hope this helps and happy coding!

  Marked as helpful

  0

  ---

  

  LuckyPort•100

  @LuckyPortPosted over 1 year ago

  dear @rileydevdzn this is what i need thanks for the suggestion will applying this in further challenges Happy Coding too thank you.

  0