Design comparison
SolutionDesign
Solution retrospective
Looking for any feedback and best practices on semantic HTML, CSS used, and a11y.
Community feedback
- @ratul0407Posted 11 months ago
@frankgomezdev congrats on completing this challenge🎉🎉
You've done a really great job. There's not a lot to complain about👍. But,
- the padding you've set to
.container
of2rem
is actually shrinking your container. You can just remove it and it looks more like the design. - It's such a small challenge and there wasn't a lot of space to add landmarks but you've done enough. The footer you've added is good but you've commented out the
.attribute
😅. I know this mistake 'cause I've also done a couple of times. Uncomment it and remove the.attribute
div as you are using afooter
- And the last nick pick that I can say, and it's completely my personal opinion that there are too many
div
element on the page. You can consider making thetop box
aarticle
.
I hope you found this helpful👍👍
Happy coding and have a very nice day😄
Marked as helpful0@frankgomezdevPosted 11 months ago@ratul0407 Thank you so much for the feedback. Very helpful and I will implement these tweaks, have a nice day!
0 - the padding you've set to
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord