Design comparison
Solution retrospective
Hello guys, I've just currently accomplished this challenge. There are some questions I would like to ask the community. Here they are :
- Do my design responsive to your devices ?
- Do you think I use a proper semantic HTML tags for my design ?
- What do you think on what aspect that I can improve my code ?
Your Feedbacks and comments would be very important for my learning journey. Thankyou guys.
Community feedback
- Account deleted
hi @bigboss7! nice work here, your solution is super clean, anyway i can give you some feedback about HTML validations and accessibility issues:
- <html> element must have a lang attribute, you can consider adding this attribute like this:
<html lang="en">- Page should contain a level-one heading(<h1> tag), you could change the following code block:
<h2>Join our community</h2> <-- delete <h1>Join our community</h1> --> add- finally, section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections, these can have a class that hides it, for example:
.hide { display: none; }I hope this feedback has been useful to you! keep coding :)
Marked as helpful0@Biggboss7Posted over 2 years ago@nachogonzalia Thankyou very much for your time and your feedback on my challenge. The first point about <html lang="en"> is a really good point. I just search on the Internet about that and notice the usage of it. Really appreciate it :) !
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord