Design comparison
SolutionDesign
Solution retrospective
How could I improve the way in which I coded this?
Community feedback
- @adonmez04Posted 9 months ago
Hi @seanbuckle. It's a good solution, keep coding. Here are some tips for you:
- I don't think you need this declaration:
flex: 1 1 11.2rem;
. If you assign an explicit size toflex-basis
, it'll break the natural behavior of the HTML. You can useflex: 1
instead. This means,flex-grow: 1;
,flex-shrink: 1;
andflex-basis: 0%;
. So your elements will share the area as the 50%, (if there are 2 elements in one row like this project) that's exactly what you want. - To keep your HTML clean, you don't need to give your list items a class to . You can use the
.card__list > li
selector to style them. It works the same way.
I hope these will help you. Keep coding and have a nice day...
Marked as helpful0 - I don't think you need this declaration:
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord