Single Price Grid component using flex

Community feedback

• 

  Christopher Till•1,070

  @chri55Posted about 4 years ago

  Hi Karin, very nice work on the design!

  One aesthetic suggestion I would recommend is putting cursor: pointer on the .button class instead of the contained a, this way the user knows the entire button is clickable.

  As for your code, very nice. You used media queries which is good, but something I'd do is make one large section for a media query at the end or beginning of the file, since it seems you wrote the same media query over again multiple times. It'll let you write less code overall! See this code on my GitHub for an example of the structure of a larger media query section. Don't mind the content, as its from a different challenge.

  Keep it up, happy coding!

  1

  ---

  

  Karin•95

  @iAmKarinPosted about 4 years ago

  Hi, thanks for your comment. I will check your code. have a great day!

  0

  

  Karin•95

  @iAmKarinPosted about 4 years ago

  @chri55 I updated my code according to your comment. Thanks for the lesson ;-) https://single-price-grid-component-master-black.vercel.app/

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted about 4 years ago

  also seems like you responsive design is broken from between 380px to about 400px wide

  0

  ---

  

  Karin•95

  @iAmKarinPosted about 4 years ago

  Hi! thanks for taking your time to check my code. I noticed this after deploying the solution. I updated my code, but i see that the link doesn't show the update. Will check it again. Have a great day! edit: don't know why my code didn't update. This is my current link: https://single-price-grid-component-master-black.vercel.app/

  0