Single price grid component using CSS Grid, Flexbox, and HTML5

Community feedback

• 

  P

  Katrien Schuermans•1,210

  @katrien-sPosted over 3 years ago

  Hello Riyana, I like your code. It looks very clean and structured.

  Just some minor remarks. Don't put a px-fontsize on the :root. There's people that have adjusted their browser to a bigger or smaller fontsize. By putting a fixed size on the :root, you force these people to read the size at 16px. I put my fontsize always on the body, in em. 16px is 1em. So people who haven't changed their settings still see the 16px, those who have, see a font that is equal to their setting.

  Ditch the min-width on your main. Or make it smaller. An iPhone 5's min-width is 320px. And I heard there's a Samsung phone going for 285px.

  Happy friday and keep on coding!

  Marked as helpful

  0

  ---

  

  Riyana Gueco•495

  @rnguecoPosted over 3 years ago

  @graficdoctor Ah, didn't know about the font-size in :root thing, thank you!

  0