Design comparison
Solution retrospective
Wasn't 100% sure about the fonts' sizes. I also don't know why my solution doesn't align with the design, in the slide comparison...
Community feedback
- @mattstuddertPosted over 4 years ago
Great work on this challenge, Pablo! The screenshots have difficulty with the
vh
element. If you were to increase top and bottoms margins instead you'd be able to get it to align.You're missing a
h1
at the moment. I'd recommend reviewing the heading hierarchy one more time. Also, you're usingarticle
tags for each area. These are typically used for distinct content that can live independently of the rest of the website content. For example, it's perfect for blog posts, articles, and forum posts that all have value in their own right. For these areas inside thesection
I'd just go with genericdiv
elements, as these are just smaller groupings of content.I hope that helps. Let me know if you have any questions! 🙂
0@pablowbkPosted over 4 years ago@mattstuddert thanks a lot for the feedback! I'll review the html and update the solution. 👍👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord