Single price grid component using CSS, Grid
Design comparison
Solution retrospective
Hello there,
This is my #2 challenge π Is there anything I could optimize in my code? Any feedback is greatly appreciated π Thank you for reviewing my code, I am happy to hear any suggestions! π
Claire
Community feedback
- @VCaramesPosted about 2 years ago
Hey @ClaireKarsenti, some suggestions to improve you code:
-
This component should be built using CSS Grid as the name of the challenge implies.
-
The β30-day, hassle-free money back guaranteeβ is not a heading. It should instead be wrapped in a Paragraph Element.
-
Remove all the commented code out from you HTML code, all it does it clutter up your code.
-
You created your button using both the Button* and Anchor Element. This is the wrong way of creating a button since only one element can be use. For this challenge you will go with the Anchor Element.
-
The button's
:hover
color is incorrect. You want to check you "style-guide" to get the correct colors. -
The βWhy Usβ list should be created using an Unordered List Element along with the List Items Element.
-
Implement a Mobile First approach π± > π₯
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
Happy Coding! π»π
Marked as helpful0@ClaireKarsentiPosted about 2 years agoHey @vcarames !
Thank you for reviewing my code :-)
I updated my code followed your suggestions :
- I have rebuild the project with Grid instead of Flexbox.
- I implemented it with the mobile first approach.
- I adjusted the hover state.
- I updated the button element.
- I removed my commented code even if I thought It might be helpful for the frontend mentor community who may have a look on my repo.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord