Single price grid component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  👋 Hi Philip!

  🎉 Congratulations on finishing this challenge! I have some feedback on this solution:

  • Accessibility
    • Create a custom :focus-visible styling to any interactive elements (button, links, input, textarea). This will make the users can navigate this website using keyboard (Tab) easily.
    • Heading levels should only increase by one. Keep in mind that a heading is like a title on a document. Do you think that this should be a heading or a title or it should be a text with emphasis?

  <h3 class="second">30-day, hassle-free money back guarantee</h3>
  

  • You should only have one h1 for every page. Heading one is working as an identifier for each page. So, I would recommend lower the level of other h1 (made the other two h1 to h2).
  • Visual
    • The Sign Up button is broken. Try to change the display to either block or inline-block and adjust the padding and margin.
    • I noticed that the layout is broken on 400px width.
  • HTML
    • I would recommend making this as a ul and wrap each text with li instead of div and p.

  <div class="lastime">
    <p class="rest">Tutorials by industry experts</p>
    <p class="rest">Peer & expert code review</p>
    <p class="rest">Coding exercises</p>
    <p class="rest">Access to our GitHub repos</p>
    <p class="rest">  Community forum</p>
    <p class="rest"> Flashcard decks</p>
    <p class="rest last-rest">New videos every week</p>
  </div> 
  

  That's it! Hopefully, this is helpful!

  Marked as helpful

  1

  ---

  

  akinsuyi philip•120

  @AkinsuyiphilipPosted almost 3 years ago

  @vanzasetia i really appreciate this thanks for the feedback

  0