Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! Here are some suggestions to help improve your code:
- This entire component should have been built using CSS Grid as the challenge name implies. If you are not comfortable using CSS Grid or do not know how use it, here is a link that is all about how to use CSS Grid:
https://css-tricks.com/snippets/css/complete-guide-grid/
-
There are three headings in this component; “Join our community”, “Monthly Subscription”, and “Why us”. They need be wrapped in a header element.
-
Your button needs to have a
:hover
. You want to look at the “style-guide and the “design files” to see how it should be. -
The “Why Us” list should be created using an Unordered List Element along with the List Items Element.
-
Remove all the
<br>
you added. They are being used incorrectly and are not needed.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful0@ChrisesbuenoPosted about 2 years ago@vcarames I feel comfortable with grid, it's just that I noticed that the challenge could be solved using flexbox and it only used one line of code, with grid it was about 4, but you're right, the challenge is to do it with grid, I already corrected it, many Thank you
0@VCaramesPosted about 2 years ago@Chrisesbueno
Once you fully master CSS grid, especially with the shorthands, you'll be able to create everything with with very few lines of code.
Keep It up!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord