Single price Grid Component

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted almost 4 years ago

  Nice work! This is good going for your first challenge. Lovely use of grid rather than media queries and your solution responds well. Some thoughts/suggestions:

  1. You could add some :hover styles to the button so that it's clear that it's reactive (and curser: pointer is a nice touch too.
  2. Instead of setting the same padding on all your divs and the parent container you could try creating a container "utility class" with the padding you want and then add that class to the elements you want the padding on. This saves repetition and makes it easier to adjust padding later on if you want to.
  3. Lastly, I'd consider using an unordered list and list items in the final div (rather than the span and br approach you opted for). This is just a bit more semantic and helpful for screenreaders (list-style and padding set to none will help).

  1

  ---

  

  InduRajput•120

  @InduRajputPosted almost 4 years ago

  @dwhenson, thank you so much for your feedback :) I will try to work on it .

  0