@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
Great job on your solution! I can see that you've implemented landmark elements like <main> and <footer>, which is excellent for accessibility. Well done!
Here are some suggestions to further improve your solution:
- Add
cursor: pointerto the button: By adding this CSS property, you'll provide visual feedback to users when hovering over the button, indicating that it's clickable.
- Use
<ul>and<li>for the content under "Why Us": Since the content is a list of items, it's more semantically correct to use an unordered list (<ul>) and list items (<li>) instead of just using paragraph (<p>).
I hope you find it useful! 😄
Happy coding!
Marked as helpful
@MatejBumbera
Posted
@MelvinAguilar Hi! Thank you for feedback. I have been thinking about making the section a list, bud it would give me an unnecessary indentation and bullet points. Is it really worth it to go through the extra trouble of removing it?
@MelvinAguilar
Posted
@MatejBumbera Hi again ! It's understandable that you might want to avoid the extra indentation but using semantic HTML elements like <ul> is considered a best practice for accessibility.
If you want to use a list, but want to remove the default bullet points and indentation, you can do so with CSS. You can set the list-style property to none and adjust the padding or margin to control the spacing as desired.
ul {
list-style: none;
padding: 0;
margin: 0;
}
Marked as helpful
@MatejBumbera
Posted
@MelvinAguilar Thanks for answer, already changed it :D
