Single price grid component solution using grid
Design comparison
Solution retrospective
Please let me know if you have some suggestions on how to improve my solution.
Community feedback
- @MelvinAguilarPosted over 1 year ago
Hello there ๐. Good job on completing the challenge !
Great job on your solution! I can see that you've implemented landmark elements like <main> and <footer>, which is excellent for accessibility. Well done!
Here are some suggestions to further improve your solution:
- Add
cursor: pointer
to the button: By adding this CSS property, you'll provide visual feedback to users when hovering over the button, indicating that it's clickable.
- Use
<ul>
and<li>
for the content under "Why Us": Since the content is a list of items, it's more semantically correct to use an unordered list (<ul>
) and list items (<li>
) instead of just using paragraph (<p>
).
I hope you find it useful! ๐
Happy coding!
Marked as helpful1@MatejBumberaPosted over 1 year ago@MelvinAguilar Hi! Thank you for feedback. I have been thinking about making the section a list, bud it would give me an unnecessary indentation and bullet points. Is it really worth it to go through the extra trouble of removing it?
1@MelvinAguilarPosted over 1 year ago@MatejBumbera Hi again ! It's understandable that you might want to avoid the extra indentation but using semantic HTML elements like <ul> is considered a best practice for accessibility.
If you want to use a list, but want to remove the default bullet points and indentation, you can do so with CSS. You can set the
list-style
property tonone
and adjust the padding or margin to control the spacing as desired.ul { list-style: none; padding: 0; margin: 0; }
Marked as helpful1@MatejBumberaPosted over 1 year ago@MelvinAguilar Thanks for answer, already changed it :D
0 - Add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord